Skip to content

Voice Receiving #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CodeWithSwastik merged 32 commits into from
Dec 20, 2021
Merged

Voice Receiving #532

CodeWithSwastik merged 32 commits into from
Dec 20, 2021

Conversation

@VincentRPS
Copy link
Contributor

@VincentRPS VincentRPS commented Dec 2, 2021 •
edited
Loading

Summary

Voice Recording Stabilizing & Building Off Of Rapptz/discord.py#6507

Checklist

  • Stabilize
    • I Would Call it Stable In It's Current State
  • Finish The TODO's
  • Possibly Rename Sink
    • Decided it didn't need to be.
  • Test With A lot of people (~10)

Bugs

  • When 2 People Talk There Is Static
    • Fixed

Checklist

  • This PR adds something new (e.g. new method or parameters).

@BobDotCom BobDotCom linked an issue Dec 2, 2021 that may be closed by this pull request
Voice Receive API #52
Closed
@BobDotCom BobDotCom added this to the v2.1 milestone Dec 2, 2021
@BobDotCom BobDotCom added feature Implements a feature priority: medium Medium Priority status: in progress Work in Progess labels Dec 2, 2021
@VincentRPS VincentRPS marked this pull request as ready for review December 6, 2021 08:21
@pgamerx
Copy link

pgamerx commented Dec 6, 2021

hello

@VincentRPS
Copy link
Contributor Author

VincentRPS commented Dec 6, 2021

@BobDotCom if you could move this into V2.0 that would be great

@krittick krittick mentioned this pull request Dec 13, 2021
Closed
@CodeWithSwastik CodeWithSwastik modified the milestones: v2.1, v2.0 Dec 15, 2021
@Lulalaby Lulalaby enabled auto-merge December 19, 2021 00:32
@Lulalaby Lulalaby disabled auto-merge December 19, 2021 00:32
@Lulalaby Lulalaby enabled auto-merge (squash) December 19, 2021 00:32
@Lulalaby Lulalaby added status: awaiting review Awaiting review from a maintainer and removed status: in progress Work in Progess labels Dec 19, 2021
CodeWithSwastik
CodeWithSwastik previously approved these changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@CodeWithSwastik CodeWithSwastik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and it works perfectly. Haven't gone through the code thoroughly yet.

@VincentRPS @CodeWithSwastik
Redo Voice Example To Use Bot Instead of Client
dc63620 
Co-Authored-By: Swas.py <61446939+CodeWithSwastik@users.noreply.github.com>
auto-merge was automatically disabled December 19, 2021 06:10

Head branch was pushed to by a user without write access

@CodeWithSwastik
Copy link
Contributor

CodeWithSwastik commented Dec 20, 2021

This can be merged when the hardcoded os stuff is removed and bytes are supported.

@VincentRPS VincentRPS changed the base branch from master to feature/voice-receive December 20, 2021 07:40
@CodeWithSwastik CodeWithSwastik merged commit 046380a into Pycord-Development:feature/voice-receive Dec 20, 2021
@VincentRPS VincentRPS mentioned this pull request Dec 20, 2021
Closed
7 tasks
@Lulalaby Lulalaby deleted the support/voice/recording branch December 20, 2021 08:37
Swhistler1
Swhistler1 reviewed Dec 21, 2021
View reviewed changes
Copy link

@Swhistler1 Swhistler1 left a comment •
edited by Lulalaby
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Pycord-Development Pycord-Development locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

2 more reviewers

@Swhistler1 Swhistler1 Swhistler1 left review comments

@CodeWithSwastik CodeWithSwastik CodeWithSwastik left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@VincentRPS VincentRPS

Labels

feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer

Projects

None yet

Milestone

v2.0

Development

Successfully merging this pull request may close these issues.

Voice Receive API

6 participants

@VincentRPS @pgamerx @CodeWithSwastik @Swhistler1 @Lulalaby @BobDotCom